Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various bugs in determineInitialMove #61

Merged
merged 4 commits into from
Nov 4, 2018
Merged

Fix various bugs in determineInitialMove #61

merged 4 commits into from
Nov 4, 2018

Conversation

aclonegeek
Copy link
Owner

@aclonegeek aclonegeek commented Nov 4, 2018 •
edited
Loading

Fixes #60
Fixes #62

@aclonegeek aclonegeek added the enhancement New feature or request label Nov 4, 2018
@aclonegeek aclonegeek added this to the Sprint 4 milestone Nov 4, 2018
laynekm
laynekm approved these changes Nov 4, 2018
View reviewed changes
Copy link
Collaborator

@laynekm laynekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks bueno to me.

@aclonegeek aclonegeek mentioned this pull request Nov 4, 2018
Closed
@aclonegeek aclonegeek changed the title Fix determineInitialMove not deleting the tiles it plays when it has a largest meld over 30 Fix various bugs in determineInitialMove Nov 4, 2018
altin
altin reviewed Nov 4, 2018
View reviewed changes
src/main/java/core/Strategy1.java
// Otherwise, adds as many melds as possible to workspace such that total points >= 30
int totalTileValue = 0;
int totalTileValue = 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this big space?

altin
altin requested changes Nov 4, 2018
View reviewed changes
Copy link
Collaborator

@altin altin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! One small nit

@altin altin merged commit 586de1f into master Nov 4, 2018
@aclonegeek aclonegeek deleted the fix_initialmove branch November 5, 2018 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altin altin altin approved these changes

@laynekm laynekm laynekm approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aclonegeek @altin @laynekm