Skip to content

Commit

Permalink
docs: add review section for PR
Browse files Browse the repository at this point in the history
  • Loading branch information
PaleBluDot committed Mar 15, 2024
1 parent 5bf02db commit 0c05db8
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions docs/pull-request.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,18 @@ Pull request should merge the working branch to `main`.

![Github Pull Request](../static/screenshots/github-pr.png)

## Reviews

1. Clone the repo `git clone https://github.com/aclu-national/email-builder.git`
2. Move into the directory with `cd email-builder`.
3. Change the branch for the PR.
4. Install all packages with `npm install`.
5. Build the templates with `npm run build`.
6. Go into the `dist/templates/base` for a built templates to test
7. Head over to [**Sailthru**](https://my.sailthru.com/#rev/today) and changed to the `ACLU-Dev` environment.
8. In the campaigns section, find the campaign `24XXXX NAT GradeAD Template Test`.
9. If everything looks good, you can finally approve the PR changes.

## Merging

We will be using `squash` to merge PRs. This compresses all commits pushed to that PR into a singular commit in the git history. This is useful when making smaller commits that all fix the same issue.
Expand Down

0 comments on commit 0c05db8

Please sign in to comment.