-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idea: Three layers #66
Comments
I think your better off doing one of the following:
As your project grows, you'll likely need to take on more of the responsibilities for managing skia, vulkan, windowing, and whatever UI you want to build within it yourself. The goal of this project is to lower that initial barrier to entry. Projects that grow beyond prototyping will (by design) outgrow it and should start relying on the underlying technologies directly. (For example, neovide still uses the renderer but no longer uses the "app" construct provided in this library because they needed more control over the event loop.) |
So wait, you're saying you want me to vendorize skulpin...? |
More specifically for the above approaches:
My comments about neovide were that they use the skulpin-renderer crate but not the "app" functionality in skulpin-app-winit. There is really not all that much code here, it's skia that's doing the heavy lifting, so if you start doing serious edits to the renderer (i.e. adding more layers to the renderer) it may very well make sense for you to vendor it. |
I don't really understand why you dislike the idea of an arbitrary number of layers, or three? Is this "I won't do it" or "I won't accept a patch that does it"? If you really want me to vendorize, fine, but I like ImGui, and the cases I can think of where I'd want to draw arbitrary bitmap data, that can be fixed with multiple layers. |
Sorry to bother you, but would things be any easier for me if I used SDL2? Could I use SDL2 to draw an image or multiple Skia layers easier? |
They finally pushed 0.10.0 to crates.io. This might change. See aclysma/skulpin#66 (GitHub), @aclysma doesn't like my multiple layer idea and is urging me to vendorize, so I could end up doing that some day.
They finally pushed 0.10.0 to crates.io. This might change. See aclysma/skulpin#66 (GitHub), @aclysma doesn't like my multiple layer idea and is urging me to vendorize, so I could end up doing that some day.
Hello Just for Googlers, the best thing to do is use I didn't really understand what those functions did, but I get it now. So, at the beginning of each layer in your application, call save() and at the end restore(). That way you can play with the transformation matrices (important for Qglif) but also zoom out and draw a console or overlay on top. So I understand now why this was closed |
No more offset/factor everywhere. Cf. aclysma/skulpin#66 (comment)
Since ImGui is quite incomplete on Vulkan, what do you think of the possibility of adding another Skia layer?
So, basically sandwiching ImGui between two Skia layers. Brilliant or horrible hack?
The text was updated successfully, but these errors were encountered: