Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macos deps #48

Merged
merged 7 commits into from
May 8, 2020
Merged

Update macos deps #48

merged 7 commits into from
May 8, 2020

Conversation

j4qfrost
Copy link
Contributor

@j4qfrost j4qfrost commented May 6, 2020

This is to allow for building coverage files per this issue servo/core-foundation-rs#357

@aclysma
Copy link
Owner

aclysma commented May 7, 2020

I'm open to bumping the macOS-specific dependencies that are already locked to specific versions. (metal/cocoa)

For the skia and ash dependencies, upstream changes are unlikely to break skulpin because they are either stable (ash) or very little of it is used (sdl2). There was more discussion of the rationale here: #42

I'm open to considering new solutions to this. I don't think the current one is ideal but I like it better than requiring a specific version of ash/skia as I was doing before.

@j4qfrost
Copy link
Contributor Author

j4qfrost commented May 7, 2020

My only concern might be that skia has a version bump before the binary is uploaded to git, which triggers a build from source. Though this is more like a mild annoyance since pragmatrix gets the binary up fairly close to pushing the source.

@aclysma aclysma merged commit 15a8d09 into aclysma:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants