React & Node.js #16
Merged
React & Node.js #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad-cooley
reviewed
Feb 16, 2021
frontend/public/index.html
Outdated
Comment on lines
7
to
9
| <meta name="theme-color" content="#000000" /> | ||
| <meta name="description" content="Web site created using create-react-app" /> | ||
| <link rel="apple-touch-icon" href="%PUBLIC_URL%/images/logo192.png" /> |
There was a problem hiding this comment.
This is fine for now. We might want to deal with analytics in the next major push.
brad-cooley
requested changes
Feb 16, 2021
| background: var(--blue); | ||
| border-radius: 15px; | ||
| height: 18px; | ||
| margin-top: -6px; | ||
| transition: width .6s ease; | ||
| transition: wiedth .6s ease; |
frontend/public/manifest.json
Outdated
| @@ -0,0 +1,25 @@ | |||
| { | |||
| "short_name": "Abacus", | |||
| "name": "Create React App Sample", | |||
frontend/.eslintrc.json
Outdated
Comment on lines
23
to
27
| // "env": { | ||
| // "browser": true, | ||
| // "es2021": true | ||
| // }, | ||
| // "plugins": ["react", "@typescript-eslint"], |
backend/server.ts
Outdated
|
|
||
| app.use(cors()) | ||
| app.use(bodyParser.json()) | ||
| // app.use(bodyParser.urlencoded({ extended: true })) |
There was a problem hiding this comment.
Do we still need this? Specifically line 24.
README.md
Outdated
| - Backend and frontend run as two seperate processes. You have two choices here | ||
| - From the repo root directory, open one terminal and run `npm run dev` | ||
| - Open two terminals (or command prompt). In one terminal run `npm start` from the `frontend` directory and in the other terminal, run `npm run dev` from the `backend` directory. | ||
| - After running the frontend (eitehr way) the terminal should open a new web browser window to `localhost:3000` |
frontend/src/pages/blue/index.tsx
Outdated
Comment on lines
21
to
27
| {/* {!hasAccess('blue') ? | ||
| <> | ||
| <DefaultNavigation /> | ||
| <Container text className="main"> | ||
| <Unauthorized /> | ||
| </Container> | ||
| </> :*/} <> |
There was a problem hiding this comment.
No need for this either because we have the logic built in below?
frontend/src/pages/blue/index.tsx
Outdated
| </Switch> | ||
| </Container> | ||
| </> | ||
| {/* } */} |
frontend/src/pages/gold/Problem.tsx
Outdated
Comment on lines
23
to
36
| {/* <a | ||
| {% if submissions['status'] == "accepted" or submissions['status'] == "pending" or not(is_logged_in()) %} | ||
| class="icon button ui disabled" | ||
| {% else %} | ||
| href="/gold/problems/{{ problem.id }}/submit" id="submit" class = "icon button ui" | ||
| {% endif %} | ||
| data-tooltip="Submit" data-position="top center" data-inverted=""> | ||
| <i class="upload icon"></i> | ||
| Submit | ||
| </a> */} | ||
| {/* <a class="icon button ui" id="stats" data-tooltip="Stats" data-position="top center" data-inverted=""> | ||
| <i class="chart bar icon"></i> | ||
| Stats | ||
| </a> */} |
frontend/src/pages/gold/Submit.tsx
Outdated
| <Block size='xs-12'> | ||
| <Form> | ||
| <Input value="scratch" style={{ display: 'none' }} /> | ||
| <Input style={{ display: 'none' }} /> {/* value={getuserinfo('scratch_username')}/>*/} |
frontend/src/pages/gold/Submit.tsx
Outdated
Comment on lines
15
to
17
| {/* {% for problem in problems %} | ||
| <option value="{{ problem['problem_id'] }}">{{ problem['problem_name'] }}</option> | ||
| {% endfor %} */} |
Jl5her
commented
Feb 16, 2021
There was a problem hiding this comment.
- Removed commented code that is no longer needed.
- Fixed typos (width, and either),
- Moved check.svg, cross.svg, and question.svg to src/assets rather than using open.kattis.com
- Update JSX.Element returned functions to specify so
- Updated gold Jinja to rudimentary React
brad-cooley
approved these changes
Feb 16, 2021
This was referenced Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split up backend and frontend to operate independently and function cooperatively.