Functional quote service app #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameetandpotatoes
force-pushed
the
integration
branch
from
22bf7e1
to
3330845
Compare
| # Since we cannot verify that a netid was valid, this doesn't work' | ||
| # case attr | ||
| # when :author | ||
| # return [400, "Invalid poster"] unless Auth.verify_user(params[attr]) |
There was a problem hiding this comment.
These would be the validations for verifying a valid netid/user. liquid did this, should we do the same?
There was a problem hiding this comment.
Leaving commented out for now
sameetandpotatoes
force-pushed
the
integration
branch
from
bf1fe23
to
008242a
Compare
sameetandpotatoes
force-pushed
the
integration
branch
from
1ab5ed4
to
1da01e2
Compare
|
Looks good to me. |
sameetandpotatoes
force-pushed
the
integration
branch
from
0ee36df
to
73a56a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't plan on getting this out before our first deploy, but I had time and wanted to update this since I already worked with a sinatra app before.
Also, I had a few questions that I had / wanted other people's opinions of, which I will make comments in the appropriate sections
UI as of now:
Approve/Delete buttons automatically show up for admins, and not for normal students.
Other PRs:
acm-uiuc/groot-desktop-frontend#43
acm-uiuc/groot#43