Skip to content
This repository has been archived by the owner on Aug 20, 2021. It is now read-only.

Config block chaining fix #123

Merged
merged 3 commits into from Jan 27, 2016
Merged

Conversation

lahmann
Copy link
Contributor

@lahmann lahmann commented Jan 27, 2016

This should fix the reported issue #122.

@acelaya
Copy link
Collaborator

acelaya commented Jan 27, 2016

Can you provide a test case covering this situation?

@lahmann
Copy link
Contributor Author

lahmann commented Jan 27, 2016

A mail.global.php config with the following contents should show this issue (and that it's solved by adding the do-while-loop):

return [
    'acmailer_options' => [
        'default' => [
            //unaltered default values from mail.global.php.dist
        ],
        'foo' => [
            'extends' => 'default',
            'message_options' => [
                'from' => 'me@here.com'
            ]
        ],
        'bar' => [
            'extends' => 'foo',
            'message_options' => [
                'to' => 'me@here.com',
                'subject' => 'Foobar subject'
            ]
        ]
    ],
];

@acelaya
Copy link
Collaborator

acelaya commented Jan 27, 2016

I mean if you can create a unit test that tests this case :-)

@lahmann
Copy link
Contributor Author

lahmann commented Jan 27, 2016

I was afraid you actually meant a unit test... ;)
Not today, maybe tomorrow.

@acelaya
Copy link
Collaborator

acelaya commented Jan 27, 2016

Perfect, thanks.

Alejandro Celaya Alastrué
El 27/1/2016 18:01, "André Lahmann" notifications@github.com escribió:

I was afraid you actually meant a unit test... ;)
Not today, maybe tomorrow.


Reply to this email directly or view it on GitHub
#123 (comment).

@lahmann
Copy link
Contributor Author

lahmann commented Jan 27, 2016

There you go. :)

@acelaya
Copy link
Collaborator

acelaya commented Jan 27, 2016

Looks good, thanks

acelaya added a commit that referenced this pull request Jan 27, 2016
@acelaya acelaya merged commit f3c1897 into acmailer:master Jan 27, 2016
@lahmann lahmann deleted the config_block_chaining_fix branch January 28, 2016 08:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants