Skip to content

Commit

Permalink
Fix stuff from tests
Browse files Browse the repository at this point in the history
ShellCheck tests have brought up a couple of issues, that I was not aware of needed to be taken care. This should fix the tests.
  • Loading branch information
zearan committed Jul 29, 2023
1 parent 2014ca9 commit 3b7be47
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions dnsapi/dns_pleskxml.sh
Original file line number Diff line number Diff line change
Expand Up @@ -386,13 +386,13 @@ _pleskxml_get_root_domain() {
# We don't actually need to check for type, name, *and* id, but it guarantees only usable lines are returned.

output="$(_api_response_split "$pleskxml_prettyprint_result" 'result' '<status>ok</status>' | sed 's/<ascii-name>/<name>/g;s/<\/ascii-name>/<\/name>/g' | grep '<name>' | grep '<id>')"
debug_output="$(printf "$output" | sed -n 's:.*<name>\(.*\)</name>.*:\1:p')"
debug_output="$(printf "%s" "$output" | sed -n 's:.*<name>\(.*\)</name>.*:\1:p')"

_debug 'Domains managed by Plesk server are:'
_debug "$debug_output"
_debug "$debug_output"

_debug "Querying Plesk server for list of additional managed domains..."

_call_api "$pleskxml_tplt_get_additional_domains"
if [ "$pleskxml_retcode" -ne 0 ]; then
return 1
Expand All @@ -405,18 +405,18 @@ _pleskxml_get_root_domain() {
# We don't actually need to check for type, name, *and* id, but it guarantees only usable lines are returned.

output_additional="$(_api_response_split "$pleskxml_prettyprint_result" 'result' '<status>ok</status>' | sed 's/<ascii-name>/<name>/g;s/<\/ascii-name>/<\/name>/g' | grep '<name>' | grep '<id>')"
debug_additional="$(printf "$output_additional" | sed -n 's:.*<name>\(.*\)</name>.*:\1:p')"
debug_additional="$(printf "%s" "$output_additional" | sed -n 's:.*<name>\(.*\)</name>.*:\1:p')"

_debug 'Additional domains managed by Plesk server are:'
_debug "$debug_additional"

# Concate the two outputs together.
output="$(printf "$output $NEWLINE $output_additional")"
debug_output="$(printf "$output" | sed -n 's:.*<name>\(.*\)</name>.*:\1:p')"

output="$(printf "%s" "$output $NEWLINE $output_additional")"
debug_output="$(printf "%s" "$output" | sed -n 's:.*<name>\(.*\)</name>.*:\1:p')"

_debug 'Domains (including additional) managed by Plesk server are:'
_debug "$debug_output"
_debug "$debug_output"

# loop and test if domain, or any parent domain, is managed by Plesk
# Loop until we don't have any '.' in the string we're testing as a candidate Plesk-managed domain
Expand Down

0 comments on commit 3b7be47

Please sign in to comment.