Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gcore dns support. #4413

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Add gcore dns support. #4413

merged 1 commit into from
Jan 11, 2023

Conversation

trulyliu
Copy link
Contributor

Add gcore dns support.

https://apidocs.gcore.com/dns

@github-actions
Copy link

Welcome
Please make sure you're read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨

@trulyliu
Copy link
Contributor Author

code formatted

@trulyliu
Copy link
Contributor Author

I have fixed the CI issues.
Could you re-trigger the action?

@trulyliu
Copy link
Contributor Author

Could you take a look at my DSN-API-Test CI ?
https://github.com/trulyliu/acme.sh/actions/runs/3581505860/jobs/6025541140
The log shows the certificate was successfully issued, but the action still got fail.

@kokizzu
Copy link

kokizzu commented Dec 29, 2022

looks ok

GCORE_Key='4179_CENSORED_389245' ./acme.sh --debug --log --issue --server letsencrypt --dns dns_gcore -d MYDOMAIN -m MYEMAIL

@Neilpang
Copy link
Member

rebase your code to the latest dev branch, and run the tests again.

@trulyliu
Copy link
Contributor Author

trulyliu commented Jan 5, 2023

rebased the code.

@trulyliu trulyliu reopened this Jan 5, 2023
@trulyliu
Copy link
Contributor Author

trulyliu commented Jan 5, 2023

@trulyliu
Copy link
Contributor Author

trulyliu commented Jan 5, 2023

Could you please approve the actions for merging?

@trulyliu
Copy link
Contributor Author

trulyliu commented Jan 6, 2023

@trulyliu trulyliu closed this Jan 6, 2023
@trulyliu trulyliu reopened this Jan 6, 2023
@Neilpang
Copy link
Member

Neilpang commented Jan 7, 2023

please add your usage to the woki page, and create a new issue for bug reporting.

thanks

@trulyliu
Copy link
Contributor Author

trulyliu commented Jan 9, 2023

Issue for gcore dns api bug reporting
#4460
Wiki updated
https://github.com/acmesh-official/acme.sh/wiki/dnsapi2#153-use-gcore-dns-api

@Neilpang Neilpang merged commit e2f05f3 into acmesh-official:dev Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants