Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Google Domains DNS API. #4542

Merged
merged 3 commits into from
Mar 27, 2023
Merged

Conversation

alexleigh
Copy link
Contributor

@alexleigh alexleigh commented Mar 7, 2023

https://domains.google/learn/gts-acme/

This is an ACME API for Google Domains customers, which is different from the Google Cloud Domains API for Google Cloud customers.

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Welcome
Please make sure you're read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨

@alexleigh
Copy link
Contributor Author

alexleigh commented Mar 7, 2023

Welcome Please make sure you're read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. We look forward to reviewing your Pull request shortly ✨

Wiki page updated here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2#157-use-google-domains-dns-api
Tracking bug added here: #4545
DNS workflow completed here: https://github.com/alexleigh/acme.sh/actions/runs/4367707406

DNS workflow succeeded for a slightly earlier version of the script: https://github.com/alexleigh/acme.sh/actions/runs/4356430668

However, new runs of the DNS workflow have been failing at the Kali Linux docker image for unrelated reasons: the current versions of packages needed by the Kali docker image have been deleted from the Kali official repos. Until Kali fixes the Docker image, the DNS workflow cannot finish.

@alexleigh
Copy link
Contributor Author

alexleigh commented Mar 7, 2023

I reached out to the Kali team who confirmed that the Kali release docker image will be working again once Kali ver 2023.1 is released. If the DNS workflow needs to work before then, the Docker test can switch to using the Kali rolling image instead of the release image. One of the acme.sh maintainers would need to determine if such a change should be made to get the tests working again.

@alexleigh
Copy link
Contributor Author

alexleigh commented Mar 8, 2023

Figured out another way to fix the Kali Linux Docker image, created acmesh-official/acmetest#21 to allow the tests to run again.

EDIT: to be clear, the above acmetest PR is not needed for this acme.sh PR to go through. The tests have already passed.

@kn007
Copy link

kn007 commented Mar 8, 2023

Test pass. (f5dac12)
Thanks for your work.

========================
CentOS 8 x64

https://domains.google/learn/gts-acme/

This is an ACME API for Google Domains customers, which is
different from the Google Cloud Domains API for Google Cloud
customers.
@alexleigh
Copy link
Contributor Author

Kali Linux repositories have updated to be consistent with each other, so the DNS workflow has been able to complete https://github.com/alexleigh/acme.sh/actions/runs/4367707406

@saudiqbal
Copy link

Working fine with me.

@sberney
Copy link

sberney commented Mar 22, 2023

Worked for me as well. Thanks for the code!

@heitbaum
Copy link

I have a number of domains at

https://console.cloud.google.com/net-services/dns/zones?referrer=search&project=abc-abc-123

one of which is “abc.com”

But when I run https://acmedns.googleapis.com/v1/acmeChallengeSets/abc.com

I get the following error.

{
  "error": {
    "code": 404,
    "message": "Domain abc.com is not managed by Google Domains.",
    "status": "NOT_FOUND"
  }
}

Can someone shed some light on this? How to make it work.

@alexleigh
Copy link
Contributor Author

If your domains are managed by Google Cloud DNS, that's a separate product from Google Domains. You can try using the Cloud DNS API to manage ACME records: https://github.com/acmesh-official/acme.sh/wiki/dnsapi#49-use-google-cloud-dns-api-to-automatically-issue-cert

@vg vg mentioned this pull request Apr 12, 2023
@moralrebuild
Copy link

Waiting the next official release for this PR.

# Created: 2023-03-02

#GOOGLEDOMAINS_ACCESS_TOKEN="xxxx"
#GOOGLEDOMAINS_ZONE="xxxx"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does one find their managed google domains 'zone'?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need for specifying a domain zone, zone is the domain for which you need the certificate.

loosecannon93 added a commit to loosecannon93/opnsense-plugins that referenced this pull request May 10, 2023
Adds support for Google Domains DNS-01 ACME challenge API added to
latest upstream acme.sh. This is separate from the Google Cloud API.

https://domains.google/learn/gts-acme/

See acmesh-official/acme.sh#4542
loosecannon93 added a commit to loosecannon93/opnsense-plugins that referenced this pull request May 10, 2023
Adds support for Google Domains DNS-01 ACME challenge API added to
latest upstream acme.sh. This is separate from the Google Cloud API.

https://domains.google/learn/gts-acme/

See acmesh-official/acme.sh#4542
loosecannon93 added a commit to loosecannon93/opnsense-plugins that referenced this pull request May 10, 2023
Adds support for Google Domains DNS-01 ACME challenge API added to
latest upstream acme.sh. This is separate from the Google Cloud API.

https://domains.google/learn/gts-acme/

See acmesh-official/acme.sh#4542
xArthasx added a commit to xArthasx/plugins that referenced this pull request Jul 8, 2023
Adds support for Google Domains DNS-01 ACME challenge API added to
latest upstream acme.sh. This is separate from the Google Cloud API.

https://domains.google/learn/gts-acme/

See acmesh-official/acme.sh#4542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants