dns_gandi: implements token in addition to the (deprecated) API key #4794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome |
|
DNS API Dev Guide and DNS-API-Test pages read ! |
|
fix the ci errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gandi Livedns is replacing API key which are user-scoped and deprecated with full access by a personal access token (PAT) which is independent of a user and can be scoped to specific parts of the Gandi API.
This PR add support for PAT. If
GANDI_LIVEDNS_TOKENenvironment variable is provided, the PAT is used instead of API key. If onlyGANDI_LIVEDNS_KEYenv. variable is provided, API key is still used.This allow a transparent update for users.
DNS Github Action performs successfully on my branch: https://github.com/zbbfufu/acme.sh/actions/runs/6156454092
I will also update Wiki (dnsapi page) accordingly when this PR will be merged.