Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4836 (Switch to new Gandi LiveDNS API) #4941

Closed

Conversation

rparenton
Copy link
Contributor

@rparenton rparenton commented Jan 7, 2024

  1. Updated LiveDNS API URL for the new API
  2. Updated authorization header syntax to allow deprecated API Keys to work with the new API

1. Updated LiveDNS API URL for the new API
2. Updated authorization header syntax for deprecated API Keys to work with the new API
Copy link

github-actions bot commented Jan 7, 2024

Welcome
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@rparenton rparenton marked this pull request as ready for review January 7, 2024 05:24
@rparenton
Copy link
Contributor Author

Welcome Please make sure you've read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. We look forward to reviewing your Pull request shortly ✨ 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

I have read the linked guides. Do I need to setup DNS API Test since this is just a fix and not a new DNS API?

@Neilpang
Copy link
Member

Neilpang commented Jan 7, 2024

yes

@rparenton
Copy link
Contributor Author

Will create a new pull request once I have DNS API Test running

@rparenton rparenton closed this Jan 11, 2024
@rparenton rparenton deleted the gandi-livedns-new-api branch January 11, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants