Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Synology DSM deploy: support DSM 6.x & user-friendly refactor. #5023

Merged
merged 12 commits into from Apr 21, 2024

Conversation

scruel
Copy link
Contributor

@scruel scruel commented Feb 25, 2024

Patch Synology DSM script to support DSM 6.x if SYNO_USE_TEMP_ADMIN=1, and refactor the code to make it more user-friendly.

  • feat: support DSM 6.x, SRM, etc.
  • refactor: unify variable naming convention
  • feat: more user-friendly logic & error messages.

Fixes: #5024, #5034, #5038, #5059

@chriscarpenter12
Copy link

Any idea when these fixes will be reviewed/merged?

@scruel
Copy link
Contributor Author

scruel commented Apr 20, 2024

@chriscarpenter12 IDK, it depends on the project owner, you may just download the patched file to use before this PR is merged.

@Neilpang Neilpang merged commit 9863e7e into acmesh-official:dev Apr 21, 2024
2 checks passed
@scruel scruel deleted the patch-dsm-deploy branch April 21, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants