Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ESLinting #92

Closed
trulyronak opened this issue Sep 24, 2019 · 2 comments
Closed

Add ESLinting #92

trulyronak opened this issue Sep 24, 2019 · 2 comments
Labels
Issue: Setup Setup for the coding environment

Comments

@trulyronak
Copy link
Member

Why

We can solve coding bugs that can lead to problems not easily checked by us, and we can combine it with prettier to ensure proper code styling

How

Use Airbnb's ESLint config and make sure it works with prettier.

Note

We should NOT enforce eslint for now since we're in crunch time, but after the portal ships we should prohibit code from being pushed without passing eslint (as a commit config / or push hook or something)
@leestanley
Copy link
Member

haha 😢

@leestanley leestanley reopened this May 5, 2020
@leestanley leestanley added the Issue: Setup Setup for the coding environment label May 5, 2020
@leestanley leestanley pinned this issue May 5, 2020
@steets250
Copy link
Member

haha 😁

@steets250 steets250 unpinned this issue May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue: Setup Setup for the coding environment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steets250 @leestanley @trulyronak