This repository has been archived by the owner on Feb 18, 2020. It is now read-only.
Prevent triggering of link that slides into spot where menu trigger is located when closing menu #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great tip - works! |
|
This is glorious - thank you! |
|
This works, thanks |
acolangelo
added a commit
that referenced
this pull request
Nov 11, 2014
Prevent triggering of link that slides into spot where menu trigger is located when closing menu
acolangelo
pushed a commit
that referenced
this pull request
Nov 11, 2014
Also added an `e.preventDefault()` call to the content click, as well as `touchend`.
This was referenced Nov 11, 2014
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a design I'm working on, when the menu trigger is tapped to close the menu, the tap also triggers the link that slides into the spot the menu trigger occupied. You can prevent this sort of thing from happening in mobile browsers by adding a preventDefault to the event, which is what I did. I'm guessing that there are other cases that I did not personally encounter where your library would benefit from this addition.
This happens in Chrome for Android and Safari on iOS. Probably other mobile browsers, too.