Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py python_requires formatting, for poetry #39

Merged
merged 1 commit into from
Feb 18, 2023
Merged

Update setup.py python_requires formatting, for poetry #39

merged 1 commit into from
Feb 18, 2023

Conversation

warmlogic
Copy link
Contributor

Including this package in project that uses Poetry https://python-poetry.org/ fails with the error Invalid python versions '>=3.4.x' on coinbasepro (0.4.0) because the python_requires argument in setup.py is incorrectly formatted.

The Python docs show that it should be like python_requires=">=3.4", instead of the current format python_requires=">=3.4.x",

@warmlogic warmlogic changed the title Update python_requires formatting, for poetry Update setup.py python_requires formatting, for poetry Feb 6, 2023
@acontry
Copy link
Owner

acontry commented Feb 18, 2023

Thank you for the PR! I will cut a new release for you.

@acontry acontry merged commit 434d42b into acontry:master Feb 18, 2023
@acontry
Copy link
Owner

acontry commented Feb 18, 2023

Released in v0.4.1: https://pypi.org/project/coinbasepro/0.4.1/

@warmlogic warmlogic deleted the mm-fix-setuppy branch February 19, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants