Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make one big bulk commit when updating/syncing snippets #6

Open
Buju77 opened this issue Apr 10, 2014 · 1 comment
Open

Make one big bulk commit when updating/syncing snippets #6

Buju77 opened this issue Apr 10, 2014 · 1 comment

Comments

@Buju77
Copy link

Buju77 commented Apr 10, 2014

Currently you are immediately commiting and pushing to the repo on each single little change. It would look better for the git history of the snippet repo to have a big bulk commit instead of a lot single commits. Eg. there will be one commit/push for each snippet you delete when you delete all local snippets

Just some pseudo code:

for each action/change do
    doChange();
    git commit
    git push
end

This would be better

for each action/change do
    doChange();
end
git commit
git push

commit and push one big change.

@acoomans
Copy link
Owner

Having a commit per change and per snippet is by design. I think it's easier to identify changes (and eventually revert them if necessary) if only one snippet is affected by a given commit. So I wouldn't move the git commit out of the loop.

Regarding the push, it seems it could be extracted out of the loop. Now I think there was a reason not to do so, but I can't honestly remember. I have to dig it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants