Write per-virus per-sample fasta in proteins-to-viruses.py #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamueh
reviewed
Dec 2, 2016
| Maintain a cache of virus/sample FASTA file names, creating the FASTA | ||
| on demand. | ||
| """ | ||
| def __init__(self, proteinGrouper): |
There was a problem hiding this comment.
You don't have an explanation for proteinGrouper.
| @@ -286,7 +336,7 @@ def toHTML(self): | |||
|
|
|||
| # Write all samples (with viruses (with proteins)). | |||
| append('<h1>Samples by virus</h1>') | |||
| for sampleName in sorted(sampleNames): | |||
| for sampleName in sampleNames: | |||
|
|
|||
| @@ -264,8 +271,9 @@ def testOneLineInEachOfTwoFilesSameVirusTitle(self): | |||
|
|
|||
| def testOneLineInEachOfTwoFilesDifferentViruses(self): | |||
| """ | |||
| If a protein grouper is given two files, each with one line from the | |||
| different viruses, its virusTitles dict must be as expected. | |||
| If a protein grouper is given two files intwo different directories, | |||
|
OK, just the trivial comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #465.