Remove CLI logic for setting AutoUpgrade if implied

This logic has instead been moved to the AppInstanceStatus as a field,
ObservedAutoUpgrade. This field is set to true if AutoUpgrade was either
explicitly set or implied by other options (the image or interval).

Signed-off-by: tylerslaton <mtslaton1@gmail.com>

pkg/cli/dev.go

@@ -3,11 +3,9 @@ package cli
 import (
 	"io"
 
-	"github.com/acorn-io/runtime/pkg/autoupgrade"
 	cli "github.com/acorn-io/runtime/pkg/cli/builder"
 	"github.com/acorn-io/runtime/pkg/dev"
 	"github.com/acorn-io/runtime/pkg/imagesource"
-	"github.com/acorn-io/z"
 	"github.com/spf13/cobra"
 )
 
@@ -66,11 +64,6 @@ func (s *Dev) Run(cmd *cobra.Command, args []string) error {
 		return err
 	}
 
-	// Ensure opts.AutoUpgrade is set if is implied by opts.AutoUpgradeInterval or imageSource.Image's pattern.
-	if opts.AutoUpgrade == nil || !*opts.AutoUpgrade {
-		opts.AutoUpgrade = z.P(autoupgrade.ImpliedAutoUpgrade(opts.AutoUpgradeInterval, imageSource.Image))
-	}
-
 	return dev.Dev(cmd.Context(), c, &dev.Options{
 		ImageSource:       imageSource,
 		Run:               opts,

pkg/cli/run.go

@@ -18,7 +18,6 @@ import (
 	"github.com/acorn-io/runtime/pkg/imagesource"
 	"github.com/acorn-io/runtime/pkg/rulerequest"
 	"github.com/acorn-io/runtime/pkg/wait"
-	"github.com/acorn-io/z"
 	"github.com/sirupsen/logrus"
 	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
@@ -243,11 +242,6 @@ func (s *Run) Run(cmd *cobra.Command, args []string) (err error) {
 		return err
 	}
 
-	// Ensure opts.AutoUpgrade is set if is implied by opts.AutoUpgradeInterval or imageSource.Image's pattern.
-	if opts.AutoUpgrade == nil || !*opts.AutoUpgrade {
-		opts.AutoUpgrade = z.P(autoupgrade.ImpliedAutoUpgrade(opts.AutoUpgradeInterval, imageSource.Image))
-	}
-
 	// Force install prompt if needed
 	_, err = c.Info(cmd.Context())
 	if err != nil {