add project validation to project client

Signed-off-by: Joshua Silverio <joshua@acorn.io>

integration/projectconfig/projectconfig_test.go

@@ -118,6 +118,8 @@ func TestCLIConfig(t *testing.T) {
 			wantRestConfigHost: "https://foo.example.com",
 			wantNamespace:      "bar",
 			wantToken:          "pass",
+			wantErr:            fmt.Errorf("project \"example.com/foo/bar\" does not exist within the current context"),
+			wantError:          true,
 		},
 		{
 			name: "Project arg overrides current project",
@@ -164,6 +166,8 @@ func TestCLIConfig(t *testing.T) {
 			wantProject:        "example.com/foo/bar",
 			wantNamespace:      "bar",
 			wantToken:          "pass",
+			wantError:          true,
+			wantErr:            fmt.Errorf("project \"example.com/foo/bar\" does not exist within the current context"),
 		},
 		{
 			name:          "Use alias",

pkg/cli/acorn.go

@@ -8,8 +8,6 @@ import (
 
 	cli "github.com/acorn-io/acorn/pkg/cli/builder"
 	"github.com/acorn-io/acorn/pkg/client/term"
-	"github.com/acorn-io/acorn/pkg/config"
-	"github.com/acorn-io/acorn/pkg/project"
 	"github.com/google/go-containerregistry/pkg/logs"
 	"github.com/pterm/pterm"
 	"github.com/sirupsen/logrus"
@@ -122,22 +120,6 @@ func (a *Acorn) PersistentPre(cmd *cobra.Command, args []string) error {
 		}
 	}
 
-	if a.Project != "" {
-		clientFactory := CommandClientFactory{
-			cmd:   cmd,
-			acorn: a,
-		}
-		cfg, err := config.ReadCLIConfig()
-		if err != nil {
-			return err
-		}
-
-		err = project.Exists(cmd.Context(), clientFactory.Options().WithCLIConfig(cfg), a.Project)
-		if err != nil {
-			return err
-		}
-	}
-
 	return nil
 }
 

pkg/cli/acorn_test.go

@@ -111,7 +111,7 @@ func TestAcornProject(t *testing.T) {
 				client: &testdata.MockClient{},
 			},
 			wantErr: true,
-			wantOut: "projects.api.acorn.io \"noproject\" not found",
+			wantOut: "project \"noproject\" does not exist within the current context",
 		},
 		{
 			name: "acorn image -j 12.badname",
@@ -131,7 +131,7 @@ func TestAcornProject(t *testing.T) {
 				client: &testdata.MockClient{},
 			},
 			wantErr: true,
-			wantOut: "invalid project name [12.badname]: can not contain \".\"",
+			wantOut: "project \"12.badname\" does not exist within the current context",
 		},
 		{
 			name: "acorn image -j badname/projectname/here",
@@ -151,7 +151,7 @@ func TestAcornProject(t *testing.T) {
 				client: &testdata.MockClient{},
 			},
 			wantErr: true,
-			wantOut: "failed to find authentication token for server badname, please run 'acorn login badname' first",
+			wantOut: "project \"badname/projectname/here\" does not exist within the current context",
 		},
 	}
 	for _, tt := range tests {

pkg/project/client.go

@@ -12,6 +12,7 @@ import (
 	"github.com/acorn-io/acorn/pkg/hub"
 	"github.com/acorn-io/acorn/pkg/system"
 	"github.com/acorn-io/baaah/pkg/restconfig"
+	"golang.org/x/exp/slices"
 	"k8s.io/client-go/rest"
 )
 
@@ -202,8 +203,8 @@ func getClient(ctx context.Context, cfg *config.CLIConfig, opts Options, project
 }
 
 func getDesiredProjects(ctx context.Context, cfg *config.CLIConfig, opts Options) (result []string, err error) {
+	projects, _, err := List(ctx, opts.WithCLIConfig(cfg))
 	if opts.AllProjects {
-		projects, _, err := List(ctx, opts.WithCLIConfig(cfg))
 		return projects, err
 	}
 	p := strings.TrimSpace(opts.Project)
@@ -213,6 +214,9 @@ func getDesiredProjects(ctx context.Context, cfg *config.CLIConfig, opts Options
 	if strings.TrimSpace(p) == "" {
 		return nil, nil
 	}
+	if len(projects) != 0 && !slices.Contains(projects, p) {
+		return nil, fmt.Errorf("project \"%s\" does not exist within the current context", p)
+	}
 	for _, project := range csvSplit.Split(p, -1) {
 		if target := cfg.ProjectAliases[project]; target == "" {
 			result = append(result, project)