Default probe for router should be tcp

Signed-off-by: Darren Shepherd <darren@acorn.io>
acorn-io · Oct 25, 2022 · ef23e77 · ef23e77
1 parent c2e5499
commit ef23e77
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/pkg/controller/appdefinition/router.go b/pkg/controller/appdefinition/router.go
@@ -102,8 +102,7 @@ func toRouter(appInstance *v1.AppInstance, routerName string, router v1.Router)
 							},
 							ReadinessProbe: &corev1.Probe{
 								ProbeHandler: corev1.ProbeHandler{
-									HTTPGet: &corev1.HTTPGetAction{
-										Path: "/",
+									TCPSocket: &corev1.TCPSocketAction{
 										Port: intstr.IntOrString{
 											IntVal: 8080,
 										},

diff --git a/pkg/controller/appdefinition/testdata/router/expected.yaml.d/deployment.yaml b/pkg/controller/appdefinition/testdata/router/expected.yaml.d/deployment.yaml
@@ -37,8 +37,7 @@ spec:
             name: http
             protocol: TCP
           readinessProbe:
-            httpGet:
-              path: /
+            tcpSocket:
               port: 8080
           resources: {}
           volumeMounts: