Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

ParseReference should be used for places digest can be used #1014

Closed
jsilverio22 opened this issue Jan 5, 2023 · 1 comment
Closed

ParseReference should be used for places digest can be used #1014

jsilverio22 opened this issue Jan 5, 2023 · 1 comment
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@jsilverio22
Copy link
Contributor

ex: acorn run -P ghcr.io/acorn-io/library/hello-world@sha256:1a6c64d2ccd0bb035f9c8196d3bfe72a7fdbddc4530dfcb3ab2a0ab8afb57eeb

should work without throwing error

@jsilverio22 jsilverio22 added the kind/bug Something isn't working label Jan 5, 2023
@jsilverio22 jsilverio22 added this to the v0.5.0 milestone Jan 5, 2023
@jsilverio22 jsilverio22 self-assigned this Jan 5, 2023
cjellick pushed a commit that referenced this issue Jan 8, 2023
fix: refactor NewTag to ParseReference

Signed-off-by: Joshua Silverio <joshua@acorn.io>
@thedadams
Copy link
Contributor

At the time of this comment, the changes involved here are at the HEAD of main.

With Acorn version built from HEAD~1:

  1. Run acorn run -P ghcr.io/acorn-io/library/hello-world@sha256:1a6c64d2ccd0bb035f9c8196d3bfe72a7fdbddc4530dfcb3ab2a0ab8afb57eeb and the following error appears complaining about the comma:
Error: App.api.acorn.io "autumn-wave" is invalid: spec.image: Invalid value: "ghcr.io/acorn-io/library/hello-world@sha256:1a6c64d2ccd0bb035f9c8196d3bfe72a7fdbddc4530dfcb3ab2a0ab8afb57eeb": repository can only contain the characters `abcdefghijklmnopqrstuvwxyz0123456789_-./`: acorn-io/library/hello-world@sha256

With the latest version of Acorn:

  1. Run acorn run -P ghcr.io/acorn-io/library/hello-world@sha256:1a6c64d2ccd0bb035f9c8196d3bfe72a7fdbddc4530dfcb3ab2a0ab8afb57eeb and the app starts without error.

jsilverio22 added a commit to jsilverio22/acorn that referenced this issue Jan 19, 2023
…corn-io#1012)

fix: refactor NewTag to ParseReference

Signed-off-by: Joshua Silverio <joshua@acorn.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants