Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Ports docs examples are misleading #636

Closed
cjellick opened this issue Aug 31, 2022 · 1 comment
Closed

Ports docs examples are misleading #636

cjellick opened this issue Aug 31, 2022 · 1 comment
Assignees
Labels
kind/documentation Improvements or additions to documentation
Milestone

Comments

@cjellick
Copy link
Member

In the ports docs section (https://docs.acorn.io/running/networking#publish-individual-ports), we say things like

-p 80       Publish port 80/tcp in the Acorn to port 80/tcp as a service load balancer.

But this is inaccurate. It will be tcp and a loadbalancer if the port in the acornfile file was tcp. If the port in the acornfile was http, this will publish as an ingress

@cjellick cjellick added the kind/documentation Improvements or additions to documentation label Aug 31, 2022
@cjellick cjellick added this to the v0.2.0 milestone Aug 31, 2022
@cjellick cjellick modified the milestones: v0.2.0, v0.3.0 Sep 1, 2022
@cjellick cjellick modified the milestones: v0.3.0, v0.4.0 Oct 3, 2022
@cjellick cjellick assigned cjellick and unassigned cloudnautique Oct 5, 2022
@cjellick cjellick assigned tylerslaton and unassigned cjellick Nov 1, 2022
tylerslaton added a commit to tylerslaton/runtime that referenced this issue Nov 8, 2022
tylerslaton added a commit to tylerslaton/runtime that referenced this issue Nov 8, 2022
cjellick pushed a commit that referenced this issue Nov 8, 2022
) (#853)

* Fix messaging in docs for  publishing/exposing ports via the CLI (#636)

Signed-off-by: tylerslaton <mtslaton1@gmail.com>
@cjellick
Copy link
Member Author

cjellick commented Nov 8, 2022

LGTM

@cjellick cjellick closed this as completed Nov 8, 2022
jsilverio22 pushed a commit to jsilverio22/acorn that referenced this issue Nov 8, 2022
…corn-io#636) (acorn-io#853)

* Fix messaging in docs for  publishing/exposing ports via the CLI (acorn-io#636)

Signed-off-by: tylerslaton <mtslaton1@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants