Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

docs: Add documentation around exposing ports for --link #1007 #1021

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

jsilverio22
Copy link
Contributor

@jsilverio22 jsilverio22 commented Jan 11, 2023

Issue: #1007
Signed-off-by: Joshua Silverio joshua@acorn.io

@jsilverio22 jsilverio22 changed the title docs: Add documentation around exposing ports for --link docs: Add documentation around exposing ports for --link #1070 Jan 11, 2023
@jsilverio22 jsilverio22 changed the title docs: Add documentation around exposing ports for --link #1070 docs: Add documentation around exposing ports for --link #1007 Jan 11, 2023
Signed-off-by: Joshua Silverio <joshua@acorn.io>
@jsilverio22
Copy link
Contributor Author

@cjellick I started adding an example to help illustrate but it seemed to get very wordy / confusing so let me know if this note calling it out is sufficient

@jsilverio22 jsilverio22 marked this pull request as ready for review January 11, 2023 00:51
Co-authored-by: Craig Jellick <craig.jellick@gmail.com>
Signed-off-by: jsilverio22 <115576434+jsilverio22@users.noreply.github.com>
@cjellick cjellick merged commit e14bbaf into acorn-io:main Jan 11, 2023
@jsilverio22 jsilverio22 deleted the links branch January 11, 2023 21:49
@sangee2004
Copy link
Contributor

Following notes is added to https://docs.acorn.io/running/linking-acorns
The port from the container being linked to must be explicitly exposed in the Acornfile i.e. ports: expose: "5432/tcp".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants