This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Avoid object lookups in config if acorn dns is disabled #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we always lookup all v1.Node objects to determine if we should lookup and use an Acorn DNS provisioned domain. We do this even if Acorn DNS is disabled, and other conditions where the v1.Node lookup is not required. This change makes it such that if Acorn DNS is specifically disabled then don't lookup v1.Node objects. Signed-off-by: Darren Shepherd <darren@acorn.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we always lookup all v1.Node objects to determine if we should
lookup and use an Acorn DNS provisioned domain. We do this even if
Acorn DNS is disabled, and other conditions where the v1.Node lookup is
not required. This change makes it such that if Acorn DNS is specifically
disabled then don't lookup v1.Node objects.
Signed-off-by: Darren Shepherd darren@acorn.io