This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Split make test target #1820
Merged
Split make test target #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split make test target into separate unit and integration targets. Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
tylerslaton
approved these changes
Jun 21, 2023
Comment on lines
+33
to
+34
| - run: TEST_FLAGS="--junitfile test-summary.xml" make unit | ||
| - run: TEST_ACORN_CONTROLLER=external TEST_FLAGS="--junitfile test-summary.xml" make integration |
There was a problem hiding this comment.
What would your thoughts be on breaking out these two steps into their own jobs? I see a few benefits here:
- Unit tests shouldn't (at least in theory) need an Acorn installation or image built. So the separated Unit job can ignore those parts.
- The Unit and Integration tests can run in parallel which would speed up the feedback loop.
- Each test type gets their own summary.
The main con is that we increase the amount of action minutes we use but not by that much.
There was a problem hiding this comment.
Totally agree that we should break this out into two distinct jobs. I chose this route for now because we effectively still get two separate go test runs with separate timeouts, but without the hassle of rewiring the test output/slack reporting or starting a new runner.
I was thinking about doing that as a follow up. WDYT?
There was a problem hiding this comment.
Yep! Sounds good to me. Totally fine with this being a follow-up.
g-linville
approved these changes
Jun 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split make test target into separate unit and integration targets.
Signed-off-by: Nick Hale 4175918+njhale@users.noreply.github.com