This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Use a public name strategy for volumes (#1892) #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <grant@acorn.io>
g-linville
commented
Jul 10, 2023
| @@ -99,7 +99,7 @@ metadata: | |||
| acorn.io/app-name: app-name | |||
| acorn.io/app-namespace: app-namespace | |||
| acorn.io/managed: "true" | |||
| acorn.io/public-name: app-name.foo | |||
| acorn.io/public-name: other-app.foo | |||
There was a problem hiding this comment.
This expected value changed because public names are now static and will not change when a new app binds an old volume.
g-linville
commented
Jul 10, 2023
| @@ -101,7 +101,7 @@ metadata: | |||
| acorn.io/app-name: app-name | |||
| acorn.io/app-namespace: app-namespace | |||
| acorn.io/managed: "true" | |||
| acorn.io/public-name: app-name.foo | |||
| acorn.io/public-name: other-app.foo | |||
There was a problem hiding this comment.
This expected value changed because public names are now static and will not change when a new app binds an old volume.
g-linville
changed the title
g-linville
changed the title
g-linville
requested review from
thedadams,
njhale,
StrongMonkey,
iwilltry42 and
tylerslaton
tylerslaton
approved these changes
Jul 10, 2023
pkg/cli/testdata/all/all_test.txt
Outdated
There was a problem hiding this comment.
Side thought - we should wire this up to the golden logic.
thedadams
approved these changes
Jul 10, 2023
Signed-off-by: Grant Linville <grant@acorn.io>
thedadams
approved these changes
Jul 11, 2023
cloudnautique
pushed a commit
to cloudnautique/runtime
that referenced
this pull request
Sep 28, 2023
Signed-off-by: Grant Linville <grant@acorn.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #1892
This changes the apiserver strategy back to public names for volumes. Previously there was an issue where the public name would change when a volume was bound, which led to syncing issues in Manager. When I made the public name static, then it was possible to have duplicate volume names.
With this PR, the public names do not change when volumes get bound, and the controller performs the proper checks to make sure it is not going to create a volume with a duplicate public name.
Checklist
This is a title (#1216). Here's an example