Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Change logserver to only print an error log if it fails #1944

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

g-linville
Copy link
Contributor

The info log that was getting printed at the start of this caused several of our e2e tests to fail last night because they were not expecting that to be present in the output. There's very little that can go wrong while starting this thing anyway, so I think it makes more sense to just log and error if there is one, and otherwise be silent.

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

Signed-off-by: Grant Linville <grant@acorn.io>
@g-linville g-linville merged commit f818cc6 into acorn-io:main Jul 19, 2023
2 checks passed
@g-linville g-linville deleted the logserver-log branch July 19, 2023 13:35
cloudnautique pushed a commit to cloudnautique/runtime that referenced this pull request Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants