This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Stop setting original image annotation on auto-upgrade apps (#1774) #1953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #1774
There was an issue related to this original image annotation and nested auto-upgrade apps that use a pattern. The image pattern (i.e.
ghcr.io/g-linville/myimage:v#.#.#
) would be displayed instead of the actual running image when the user ranacorn ps
. For nested auto-upgrade apps, unlike other nested apps, thestatus.AppImage.Name
field is set to the actual, proper image name, so we can just utilize that and not set the original image annotation on them at all, and that fixes the problem.Checklist
This is a title (#1216)
. Here's an example