Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Stop setting original image annotation on auto-upgrade apps (#1774) #1953

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

g-linville
Copy link
Contributor

@g-linville g-linville commented Jul 20, 2023

for #1774

There was an issue related to this original image annotation and nested auto-upgrade apps that use a pattern. The image pattern (i.e. ghcr.io/g-linville/myimage:v#.#.#) would be displayed instead of the actual running image when the user ran acorn ps. For nested auto-upgrade apps, unlike other nested apps, the status.AppImage.Name field is set to the actual, proper image name, so we can just utilize that and not set the original image annotation on them at all, and that fixes the problem.

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

Signed-off-by: Grant Linville <grant@acorn.io>
Signed-off-by: Grant Linville <grant@acorn.io>
@g-linville g-linville changed the title Set original image anno for auto-upgrade apps properly Don't set original image annotation on auto-upgrade apps Jul 20, 2023
@g-linville g-linville changed the title Don't set original image annotation on auto-upgrade apps Stop setting original image annotation on auto-upgrade apps Jul 20, 2023
@g-linville g-linville changed the title Stop setting original image annotation on auto-upgrade apps Stop setting original image annotation on auto-upgrade apps (#1774) Jul 20, 2023
@g-linville g-linville marked this pull request as ready for review July 20, 2023 15:38
@g-linville g-linville merged commit 2008864 into acorn-io:main Jul 20, 2023
2 checks passed
@g-linville g-linville deleted the original-image-fix branch July 20, 2023 19:23
cloudnautique pushed a commit to cloudnautique/runtime that referenced this pull request Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants