Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Let job fail three times before breaking the watch in acorn run #1960

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

g-linville
Copy link
Contributor

We decided earlier today to change this so that the job has to fail three times before we quit watching/waiting on the new app after running acorn run.

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

Signed-off-by: Grant Linville <grant@acorn.io>
@g-linville g-linville merged commit 547b290 into acorn-io:main Jul 21, 2023
2 checks passed
@g-linville g-linville deleted the fix-acorn-run-watch branch July 21, 2023 13:49
cloudnautique pushed a commit to cloudnautique/runtime that referenced this pull request Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants