Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Remove non-HTTP ports from ExternalName Services #1991

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Remove non-HTTP ports from ExternalName Services #1991

merged 2 commits into from
Jul 28, 2023

Conversation

g-linville
Copy link
Contributor

This should satisfy both Istio and Traefik. Traefik requires ports to be specified on HTTP ExternalName Services in order for ingress to function properly. Istio does a lot of damage if any ports are specified on TCP/UDP (but not HTTP) ExternalName Services, as documented in this issue: istio/istio#20703

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

@g-linville
Remove bad ports
f37c4f1 
Signed-off-by: Grant Linville <grant@acorn.io>
@g-linville
Add comment
84cced2 
Signed-off-by: Grant Linville <grant@acorn.io>
StrongMonkey
StrongMonkey approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@StrongMonkey StrongMonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy cow, nice work!!! 💯

tylerslaton
tylerslaton approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@tylerslaton tylerslaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job finding this.

@g-linville g-linville merged commit 91cc9a8 into acorn-io:main Jul 28, 2023
4 checks passed
@g-linville g-linville deleted the remove-bad-ports branch July 28, 2023 14:45
cloudnautique pushed a commit to cloudnautique/runtime that referenced this pull request Sep 28, 2023
@g-linville @cloudnautique
Remove non-HTTP ports from ExternalName Services (acorn-io#1991)
2c1ab97 
Signed-off-by: Grant Linville <grant@acorn.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StrongMonkey StrongMonkey StrongMonkey approved these changes

@iwilltry42 iwilltry42 iwilltry42 approved these changes

@tylerslaton tylerslaton tylerslaton approved these changes

@ibuildthecloud ibuildthecloud Awaiting requested review from ibuildthecloud

@cloudnautique cloudnautique Awaiting requested review from cloudnautique

@cjellick cjellick Awaiting requested review from cjellick

@thedadams thedadams Awaiting requested review from thedadams

@njhale njhale Awaiting requested review from njhale

@keyallis keyallis Awaiting requested review from keyallis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@g-linville @StrongMonkey @iwilltry42 @tylerslaton