This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
change: adjustments to support ImageRoleBindings in Manager #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwilltry42
requested review from
thedadams,
njhale,
g-linville and
tylerslaton
iwilltry42
force-pushed
the
change/imagerolebinding-support
branch
from
4a925e9
to
b77e088
Compare
g-linville
approved these changes
Sep 6, 2023
| @@ -120,7 +120,7 @@ func TestImageAllowRules(t *testing.T) { | |||
| assert.Error(t, err, "should error since image is not covered by images scope of IAR") | |||
|
|
|||
| // update image allow rule to cover that image | |||
| iar.Images = []string{tagName} | |||
| iar.Images = []string{"**"} | |||
There was a problem hiding this comment.
I will merge that change away with #2113 👍
thedadams
approved these changes
Sep 6, 2023
iwilltry42
commented
Sep 6, 2023
Signed-off-by: Thorsten Klein <tk@thklein.io>
Signed-off-by: Thorsten Klein <tk@thklein.io>
Signed-off-by: Thorsten Klein <tk@thklein.io>
This reverts commit 469b636. Signed-off-by: Thorsten Klein <tk@thklein.io>
iwilltry42
force-pushed
the
change/imagerolebinding-support
branch
from
7c3da38
to
353e405
Compare
cloudnautique
pushed a commit
to cloudnautique/runtime
that referenced
this pull request
Sep 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some refactoring to expose functionality to manager to use with the new ImageRoleBindings feature.
Checklist
This is a title (#1216). Here's an example