This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Make cluster-scoped permission encompass project-scoped #2207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
force-pushed
the
cluster-grant-project
branch
from
90c6798
to
dac2a1d
Compare
After this change, if you are granted cluster-scoped permission, then you are also grant project-scoped for any project. This commit also includes some simplifications to the handler that checks permissions. Signed-off-by: Donnie Adams <donnie@acorn.io>
thedadams
force-pushed
the
cluster-grant-project
branch
from
dac2a1d
to
b9f71f3
Compare
cjellick
approved these changes
Oct 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change, if you are granted cluster-scoped permission, then
you are also grant project-scoped for any project.
This commit also includes some simplifications to the handler that
checks permissions.