This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Re-evaluate image permissions for failing apps #2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njhale
approved these changes
Oct 4, 2023
thedadams
force-pushed
the
new-ira-bump-apps
branch
from
7d7c046
to
3122a8a
Compare
When an IRA is added or updated, this change will allow apps with failing image permissions to be re-evaluated in case the IRA now allows the app to run. Signed-off-by: Donnie Adams <donnie@acorn.io>
thedadams
force-pushed
the
new-ira-bump-apps
branch
from
3122a8a
to
1007f03
Compare
iwilltry42
reviewed
Oct 5, 2023
| if !iraEnabled { | ||
| app.Status.Staged.ImagePermissionsDenied = nil | ||
| } | ||
| func CheckPermissions(req router.Request, _ router.Response) error { |
There was a problem hiding this comment.
I think we may have kept the transport here and passed it on to checkImageAllowed and also to getAuthorizedPermissions, since it's useful as a remoteOpts for the signature checks.
Just seeing that you dropped it reminded me, that I didn't use it here 🙄
There was a problem hiding this comment.
Please add it back if you think it is necessary. Since things were working and we weren't using it, I removed it.
iwilltry42
reviewed
Oct 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an IRA is added or updated, this change will allow apps with failing image permissions to be re-evaluated in case the IRA now allows the app to run.