Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Improve container build time in Getting Started document. #623

Merged

Conversation

eengelking
Copy link
Contributor

Updated the Dockerfile section to improve load time from ~7s to ~2s each time a change is made to code.

@cjellick
Copy link
Member

@iwilltry42 can you test this and approve if it works?

@iwilltry42
Copy link
Contributor

iwilltry42 commented Aug 26, 2022

Hey @eengelking , thanks for this optimization!
It makes total sense the way the layering works, so that requirements don't have to be installed everytime something in the code is changed 👍
In my tests, subsequent builds went from 8.7s to 3.2s for the whole acorn build . process.
In the getting-started guide we also use the dev mode, which works around this for development by live-reloading code with Flask :)

Copy link
Contributor

@iwilltry42 iwilltry42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eengelking
Copy link
Contributor Author

In the getting-started guide we also use the dev mode, which works around this for development by live-reloading code with Flask :)

@iwilltry42 In this usecase, I was using the --dev or -i flags, but I was updating the Acornfile welcome argument instead of the Python code directly. As a result, it doesn't allow the Flask live reload to be taken into consideration.

Thank you for the approval. 👍

@cjellick cjellick merged commit 8699e49 into acorn-io:main Aug 26, 2022
@cjellick
Copy link
Member

Thanks @eengelking!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants