Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Bump linter version #628

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Bump linter version #628

merged 1 commit into from
Aug 29, 2022

Conversation

azazeal
Copy link
Contributor

@azazeal azazeal commented Aug 28, 2022

This PR bumps golangc-lint's version to v1.49.0. This will, probably, allow #593 to not break its build.

Signed-off-by: Panagiotis Siatras azazeal@users.noreply.github.com

@azazeal azazeal marked this pull request as ready for review August 28, 2022 14:42
@cjellick
Copy link
Member

Thanks!

I see 1.49.0 was released 5 days ago. Want to update this pr to use that or is there a specific reason you chose not to?

Signed-off-by: Panagiotis Siatras <azazeal@users.noreply.github.com>
@azazeal
Copy link
Contributor Author

azazeal commented Aug 29, 2022

Thanks!

I see 1.49.0 was released 5 days ago. Want to update this pr to use that or is there a specific reason you chose not to?

No particular reason; my mind was still at 1.48 is all. I've forced pushed a new commit to address this.

@cjellick
Copy link
Member

cjellick commented Aug 29, 2022

cool. assuming build goes green, ill merge

@azazeal
Copy link
Contributor Author

azazeal commented Aug 29, 2022

👋 @cjellick - would you like me to merge this? cause I can't 😂

@ibuildthecloud
Copy link
Member

@azazeal github is strangley broken on merging right now.

@ibuildthecloud ibuildthecloud merged commit c39b189 into acorn-io:main Aug 29, 2022
@azazeal azazeal deleted the bump/linter branch August 29, 2022 20:38
@azazeal azazeal mentioned this pull request Aug 31, 2022
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants