Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

go: rewrite interface{} as any #652

Merged
merged 1 commit into from
Sep 7, 2022
Merged

go: rewrite interface{} as any #652

merged 1 commit into from
Sep 7, 2022

Conversation

azazeal
Copy link
Contributor

@azazeal azazeal commented Sep 2, 2022

This PR rewrites instances of interface{} as any. It was generated with the help of gofmt and, more specifically, via executing gofmt -w -r 'interface{} -> any' . inside the root of the repository, manually excluding the following files (which look to be autogenerated):

  • pkg/apis/api.acorn.io/v1/conversion.go
  • pkg/apis/internal.acorn.io/v1/map.go
  • pkg/openapi/generated/openapi_generated.go

As an added benefit, running gofmt also fixed the format of the following files:

  • pkg/cli/pull.go
  • pkg/cli/secret_rm.go
  • pkg/cli/start.go
  • pkg/cli/stop.go
  • pkg/cli/tag.go
  • pkg/client/info.go
  • pkg/version/version.go

which were not properly formatted.

Signed-off-by: Panagiotis Siatras azazeal@users.noreply.github.com

@azazeal azazeal marked this pull request as ready for review September 2, 2022 17:34
Signed-off-by: Panagiotis Siatras <azazeal@users.noreply.github.com>
@ibuildthecloud
Copy link
Member

Oh cool, I was just thinking as I was removing references to ioutil that we should move everything to any. Thanks.

@azazeal
Copy link
Contributor Author

azazeal commented Sep 2, 2022

Not quite sure what broke the build, might it be possible this is a flaky test? If so, could we rerun the build one more time, please?

@cjellick
Copy link
Member

cjellick commented Sep 2, 2022

Github is 500ing on me, so I cannot see the build. But yeah, we started seeing a flaky test yesterday. If it's the same one, i'll rerun until we get a clean build.

@ibuildthecloud we probably need to dig further into that failure

@azazeal
Copy link
Contributor Author

azazeal commented Sep 6, 2022

So, this is definitely a flaky test, @cjellick, as it also broke #661 (which didn't touch any of the Go code) 😭

@ibuildthecloud ibuildthecloud merged commit 1545d7e into acorn-io:main Sep 7, 2022
@azazeal azazeal deleted the go/any branch September 7, 2022 10:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants