This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Validate credentials when performing a login #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerslaton
force-pushed
the
validate-creds
branch
2 times, most recently
from
3015a91
to
74f6b2f
Compare
cjellick
reviewed
Nov 2, 2022
tylerslaton
added a commit
to tylerslaton/runtime
that referenced
this pull request
Nov 2, 2022
Signed-off-by: tylerslaton <mtslaton1@gmail.com>
tylerslaton
force-pushed
the
validate-creds
branch
from
74f6b2f
to
7a5064e
Compare
tylerslaton
added a commit
to tylerslaton/runtime
that referenced
this pull request
Nov 2, 2022
Signed-off-by: tylerslaton <mtslaton1@gmail.com>
tylerslaton
force-pushed
the
validate-creds
branch
from
7a5064e
to
de390c6
Compare
tylerslaton
added a commit
to tylerslaton/runtime
that referenced
this pull request
Nov 2, 2022
Signed-off-by: tylerslaton <mtslaton1@gmail.com>
tylerslaton
force-pushed
the
validate-creds
branch
from
de390c6
to
65d38e9
Compare
|
Working through some issues moving to server side where the existing tests are validating against registries that do not exist. |
tylerslaton
force-pushed
the
validate-creds
branch
from
398e84e
to
ff7ae07
Compare
tylerslaton
added a commit
to tylerslaton/runtime
that referenced
this pull request
Nov 3, 2022
Signed-off-by: tylerslaton <mtslaton1@gmail.com>
tylerslaton
force-pushed
the
validate-creds
branch
from
ff7ae07
to
1f5781f
Compare
tylerslaton
added a commit
to tylerslaton/runtime
that referenced
this pull request
Nov 3, 2022
Signed-off-by: tylerslaton <mtslaton1@gmail.com>
tylerslaton
force-pushed
the
validate-creds
branch
from
1f5781f
to
7e27f1c
Compare
Signed-off-by: tylerslaton <mtslaton1@gmail.com>
tylerslaton
force-pushed
the
validate-creds
branch
from
7e27f1c
to
f7f824c
Compare
|
Okay, got the tests passing again. Looks like there was an issue with the listing functionality not properly running. |
cjellick
approved these changes
Nov 10, 2022
|
@tylerslaton - just an async heads up: this is actually still client side pkg/client is called by pkg/cli, before the call goes to the server. To get this call server side, it should have landed in https://github.com/acorn-io/acorn/blob/main/pkg/server/registry/apps/strategy.go No action needed on your part, I'm going to see if we can fix today as part of v0.4.1. Just wanted to let you know asyncronously for future reference (assuming you get a notification of this comment :-) ) |
|
@cjellick Ah, right on. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in a new function that validates the credentials against the specified registry. If the validation fails it will return an error and not add it to the Acorn credentials.
Issue #324