Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Automatic Let's Encrypt certificates for user-provided domains #836

Merged
merged 6 commits into from
Nov 16, 2022

Conversation

iwilltry42
Copy link
Contributor

@iwilltry42 iwilltry42 commented Nov 2, 2022

Note: This uses the HTTP01 challenge, which requires port 80 (on the ingress controller) to be accessible from the outside.

Other Changes

  • moved let's encrypt logic to its own package (including the wildcard certificate logic)
  • the on-acorn.io wildcard certificate is now treated just like any other certificate, meaning that the certificate secret handler will renew it if needed (independent from the DNS config handler)

To-Do

  • Move long-running jobs to goroutines
  • Proper "locking" for running requests
  • Hashing the ACME Account should include the Private Key which is the actual identifier
    • Scratch that, the private key should be re-generated if URL/E-Mail changed as we'd re-register an ACME account in that case.

Ref #206 & #486

- moved TLS functionality out of acorn package
- created new router middlewares to filter for acorn-managed TLS secrets
- implement handler skeletons for initial provisioning and renewal of
  certificates

Signed-off-by: Thorsten Klein <tk@thklein.io>
Signed-off-by: Thorsten Klein <tk@thklein.io>
Signed-off-by: Thorsten Klein <tk@thklein.io>
Signed-off-by: Thorsten Klein <tk@thklein.io>
…nd user-provided domain certificates

Signed-off-by: Thorsten Klein <tk@thklein.io>
… tls renewal tasks

Signed-off-by: Thorsten Klein <tk@thklein.io>
@cjellick cjellick merged commit 6ded642 into acorn-io:main Nov 16, 2022
@iwilltry42 iwilltry42 deleted the iwilltry42/issue206 branch November 17, 2022 07:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants