This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
fix: acorn rm refactor and include rm subcmds #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Silverio <joshua@acorn.io>
Signed-off-by: Joshua Silverio <joshua@acorn.io>
Signed-off-by: Joshua Silverio <joshua@acorn.io>
Signed-off-by: Joshua Silverio <joshua@acorn.io>
Signed-off-by: Joshua Silverio <joshua@acorn.io>
Signed-off-by: Joshua Silverio <joshua@acorn.io>
Signed-off-by: Joshua Silverio <joshua@acorn.io>
Signed-off-by: Joshua Silverio <joshua@acorn.io>
tylerslaton
reviewed
Nov 10, 2022
Signed-off-by: Joshua Silverio <joshua@acorn.io>
Signed-off-by: Joshua Silverio <joshua@acorn.io>
Signed-off-by: Joshua Silverio <joshua@acorn.io>
cjellick
reviewed
Nov 16, 2022
cjellick
reviewed
Nov 16, 2022
cjellick
reviewed
Nov 16, 2022
cjellick
reviewed
Nov 16, 2022
cjellick
reviewed
Nov 16, 2022
Signed-off-by: Joshua Silverio <joshua@acorn.io>
Signed-off-by: Joshua Silverio <joshua@acorn.io>
|
good to merge @cjellick? |
cjellick
approved these changes
Nov 17, 2022
|
yes, let me merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #346
This PR address the acorn rm not being user friendly. It adds the rm command to each subcommand (image, volume, container). It also refactors acorn rm to included types and force flags and be centered around acorn app-names. A user can do
and this will prompt user to remove all containers/volumes associated with the acorn.
Another example to delete all would be
This will force delete all resources associated with the acorn