This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Cli testing #869
Merged
Cli testing #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsilverio22
force-pushed
the
cli-test
branch
2 times, most recently
from
390ca00
to
a28079f
Compare
jsilverio22
force-pushed
the
cli-test
branch
from
23064c0
to
4616813
Compare
tylerslaton
suggested changes
Nov 28, 2022
pkg/cli/acorn_test.go
Outdated
| client: &testdata.MockClient{}, | ||
| }, | ||
| wantErr: false, | ||
| wantOut: "Acorn: Containerized Application Packaging Framework\n\nUsage:\n acorn [flags]\n acorn [command]\n\nAvailable Commands:\n all List (almost) all objects\n app List or get apps\n build Build an app from a Acornfile file\n check Check if the cluster is ready for Acorn\n container Manage containers\n credential Manage registry credentials\n exec Run a command in a container\n help Help about any command\n image Manage images\n info Info about acorn installation\n install Install and configure acorn in the cluster\n login Add registry credentials\n logout Remove registry credentials\n logs Log all pods from app\n pull Pull an image from a remote registry\n push Push an image to a remote registry\n render Evaluate and display an Acornfile with args\n rm Delete an app, container, secret or volume\n run Run an app from an image or Acornfile\n secret Manage secrets\n start Start an app\n stop Stop an app\n tag Tag an image\n uninstall Uninstall acorn and associated resources\n update Update a deployed app\n volume Manage volumes\n wait Wait an app to be ready then exit with status code 0\n\nFlags:\n -A, --all-namespaces Namespace to work in\n --context string Context to use in the kubeconfig file\n --debug Enable debug logging\n --debug-level int Debug log level (valid 0-9) (default 7)\n -h, --help help for acorn\n --kubeconfig string Location of a kubeconfig file\n --namespace string Namespace to work in (default \"acorn\")\n\nUse \"acorn [command] --help\" for more information about a command.\n", |
There was a problem hiding this comment.
Could we swap this to be ``` instead? That would make it a bit more natural to read for the future. If we want to cut down on lines, we could alternatively look at creating a testdata dir like some of the other tests have. Inside of that we could have a sub-directory called `acorn` and in that we could have a file of expect output for each of these tests.
Doing either of those things should make it less of a hassle when adding new tests that have expected console output since we won't need to add any formatting characters.
| commandContext client.CommandContext | ||
| }{ | ||
| { | ||
| name: "acorn render .", fields: fields{ |
There was a problem hiding this comment.
We should test the happy path for this as well.
jsilverio22
force-pushed
the
cli-test
branch
from
45a73a3
to
0323d94
Compare
jsilverio22
force-pushed
the
cli-test
branch
3 times, most recently
from
b09b75a
to
8e7cb2c
Compare
cjellick
approved these changes
Dec 2, 2022
Signed-off-by: Joshua Silverio <joshua@acorn.io>
cjellick
approved these changes
Dec 2, 2022
tylerslaton
approved these changes
Dec 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #868