This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Fix profiles with permissions #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerslaton
requested review from
ibuildthecloud and
cjellick
and removed request for
ibuildthecloud
tylerslaton
force-pushed
the
fix-profile-permissions
branch
2 times, most recently
from
1eed679
to
0cc362d
Compare
Prior to this commit, validation of permissions was not being calculated using the params set by the users. For example, profiles were not being taken into account when setting conditional permissions. On top of fixing this, this also adds an update to launch.json to allow specifying the Acornfile or image to run. Signed-off-by: tylerslaton <mtslaton1@gmail.com>
tylerslaton
force-pushed
the
fix-profile-permissions
branch
from
0cc362d
to
f4f5e70
Compare
ibuildthecloud
approved these changes
Dec 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an issue where an Acorn that defines permissions conditionally based on profiles would always request the conditional permissions.
Before,
acorn run registry/org/repo:conditional-permissionswould ask for permissions the same way thatacorn run --profile=with-permissions registry/org/repo:conditional-permissionswould.Now,
acorn run registry/org/repo:conditional-permissionsdoes not ask for permissions andacorn run --profile=with-permissions registry/org/repo:conditional-permissionsdoes.Also, I added an input prompt for the Acorn file or image to run for vscode's
acorn runlaunch configuration.