-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
ping @dariocravero |
ping @dariocravero any progress? |
FYI I've merged this into my fork (https://github.com/Rich-Harris/acorn-object-spread) so that I can update Bublé — you can |
I updated the plugin to acorn 5, see my fork: https://github.com/adrianheine/acorn5-object-spread |
Hey everyone, I'm sorry for not being able to follow up on this. @adrianheine, I see your fork is already merged in buble which makes sense. I can make you a collaborator on npm or transfer the ownership of the package to you if you're happy with that. As for the repo, I don't mind where it is, I can add you all to this repo if you want to continue using it or it can move to Adrian's. I can merge your changes here. |
Hi @dariocravero, if you want to be an active maintainer I'm happy with moving development back into this repo and your npm package. I'd like to be a collaborator at both places then :) |
Hi @adrianheine, I don't think I'll be able to actively maintain it, as in, write code for it, these days. If you feel more comfortable working on your own repo, that's ok with me, I can close this one and put a note on the README saying it moved over to your GitHub. I'm also happy to give you the NPM package name, if you want to use it. |
@adrianheine @dariocravero ping ? |
Sorry for the silence. How about we move this repo to the new acornjs organization? |
@adrianheine how do we go about it? :) |
I think you can just transfer ownership in the repository settings. |
@adrianheine, just tried but github tells me |
I finally figured out an obvious way to do this: You could add me to this repo since I can create repositories on acornjs. |
@adrianheine done! Thanks! |
Since acorn 5.4 has support of rest and spread properties builtin, I think we can just deprecate this repository and package. I'm gonna do the same with acorn5-object-spread. |
I'm trying to get all of Buble's dependencies working on acorn 4.x for packaging reasons. Buble's tests pass with acorn 4.x in #2, but not with commit 0da4568, so I've reverted it and proposed this PR.