Skip to content
This repository has been archived by the owner on Jun 12, 2020. It is now read-only.

Acorn 4.x #3

Closed
wants to merge 4 commits into from
Closed

Acorn 4.x #3

wants to merge 4 commits into from

Conversation

jbboehr
Copy link

@jbboehr jbboehr commented Apr 21, 2017

I'm trying to get all of Buble's dependencies working on acorn 4.x for packaging reasons. Buble's tests pass with acorn 4.x in #2, but not with commit 0da4568, so I've reverted it and proposed this PR.

@jbboehr
Copy link
Author

jbboehr commented May 11, 2017

ping @dariocravero

@victor-homyakov
Copy link

ping @dariocravero any progress?

@Rich-Harris
Copy link

FYI I've merged this into my fork (https://github.com/Rich-Harris/acorn-object-spread) so that I can update Bublé — you can npm install Rich-Harris/acorn-object-spread until Dario is able to merge this

@adrianheine
Copy link
Member

I updated the plugin to acorn 5, see my fork: https://github.com/adrianheine/acorn5-object-spread
While this pull request is compatible with acorn 5, it also degrades acorn 5's support for async as property name.

@dariocravero
Copy link
Contributor

dariocravero commented Nov 5, 2017

Hey everyone, I'm sorry for not being able to follow up on this.

@adrianheine, I see your fork is already merged in buble which makes sense.

I can make you a collaborator on npm or transfer the ownership of the package to you if you're happy with that.

As for the repo, I don't mind where it is, I can add you all to this repo if you want to continue using it or it can move to Adrian's. I can merge your changes here.

@dariocravero dariocravero reopened this Nov 5, 2017
@adrianheine
Copy link
Member

Hi @dariocravero, if you want to be an active maintainer I'm happy with moving development back into this repo and your npm package. I'd like to be a collaborator at both places then :)

@dariocravero
Copy link
Contributor

Hi @adrianheine, I don't think I'll be able to actively maintain it, as in, write code for it, these days. If you feel more comfortable working on your own repo, that's ok with me, I can close this one and put a note on the README saying it moved over to your GitHub. I'm also happy to give you the NPM package name, if you want to use it.

@Scrum
Copy link

Scrum commented Dec 18, 2017

@adrianheine @dariocravero ping ?

@adrianheine
Copy link
Member

Sorry for the silence. How about we move this repo to the new acornjs organization?

@dariocravero
Copy link
Contributor

@adrianheine how do we go about it? :)

@adrianheine
Copy link
Member

I think you can just transfer ownership in the repository settings.

@dariocravero
Copy link
Contributor

@adrianheine, just tried but github tells me You don’t have the permission to create repositories on acornjs :(

@adrianheine
Copy link
Member

I finally figured out an obvious way to do this: You could add me to this repo since I can create repositories on acornjs.

@dariocravero
Copy link
Contributor

@adrianheine done! Thanks!

@adrianheine
Copy link
Member

Since acorn 5.4 has support of rest and spread properties builtin, I think we can just deprecate this repository and package. I'm gonna do the same with acorn5-object-spread.

@jbboehr jbboehr closed this Feb 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants