Treat function declarations in modules as lexical

Closes #714
acornjs · Aug 6, 2018 · 2cd1d9a · 2cd1d9a · jdalton · Aug 6, 2018
1 parent a7dd5fa
commit 2cd1d9a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/statement.js b/src/statement.js
@@ -498,7 +498,7 @@ pp.parseFunction = function(node, isStatement, allowExpressionBody, isAsync) {
   if (isStatement) {
     node.id = isStatement === "nullableID" && this.type !== tt.name ? null : this.parseIdent()
     if (node.id) {
-      this.checkLVal(node.id, "var")
+      this.checkLVal(node.id, this.inModule ? "let" : "var")
     }
   }
 

diff --git a/test/tests-harmony.js b/test/tests-harmony.js
@@ -16237,3 +16237,5 @@ test('for ([...foo, bar].baz in qux);', {
   ],
   "sourceType": "script"
 }, {ecmaVersion: 6})
+
+testFail("var f;\nfunction f() {}", "Identifier 'f' has already been declared (2:9)", {ecmaVersion: 6, sourceType: "module"});