Add support for ES2024 Regex v flag #1219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marijnh
reviewed
May 23, 2023
acorn/src/regexp.js
Outdated
| ) { | ||
| pos = state.pos | ||
| } | ||
| state.pos = pos |
There was a problem hiding this comment.
Is it actually valid for --/&& to occur but then not be followed by a set operand? If not, why not move the parsing of the operand into the if and make it raise rather than return a boolean?
There was a problem hiding this comment.
I changed it to raise an error if the operator is not followed by an operand.
0265d1b
|
Thanks for integrating all my comments! |
|
Thank you for the many reviews! I will check the follow up diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #1216 and #1218.