New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loose parser: fixes and ES6 #151
Conversation
…Token`. Allows to avoid both custom `testAssert` and adding extra arguments in `test`.
Includes correction of mistype ".." vs "...".
Removed "kind" from tests for ES6 import/export as it's left only for backward compatibility.
Great work! Please put additional testing logic in My lint tool spotted a bunch of suspicious things:
I'm also not sure about the tokenizer magic, I expect you understand the problem more completely than I do. |
@marijnh Oh, right, in the beginning I was going to update web-driver too, but forgot until the moment of submitting PR. Will do. Will check possible problems, thanks. |
@marijnh Ah - linter is right, I copy-pasted |
Regarding tokenizer magic - it's not that much problem with functionality but rather with understanding what is the best way to share it between acorn and acorn_loose parsers (as you already did with |
* Added support for acorn_loose and grouped log to web-driver. * Removed unused copy-pasted `parseTemplate` from loose parser. * Throw non-SyntaxError errors immediately (as those are generic).
I've done some more work to make all tests pass for the loose parser, excluding the ones that use template strings. See attached patch. I've merged this into master. |
Define Program node extent to be the whole program, make both parser and the tests conform to this. Fix a bunch of bugs in the loose parser's handling of corner cases. Issue #151
@marijnh Thanks! I'll check what I can about template strings, it shouldn't be too hard to implement them. |
Fixes Aether acornjs#151 Improves Filbert #20
Done:
Not done: