Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow build to exclude internal avresample #77

Merged
merged 2 commits into from Dec 23, 2021

Conversation

johnsheu
Copy link
Contributor

This allows the build to complete without using FFmpeg-derived code,
though this disables input resampling and thus requires that input
audio to the fingerprinter is already at the configured fingerprint
sample rate.

This allows the build to complete without using FFmpeg-derived code,
though this disables input resampling and thus requires that input
audio to the fingerprinter is already at the configured fingerprint
sample rate.
@lalinsky
Copy link
Member

Hm, we could do this. I just need to verify the resampling configs, to make sure they match. I used the internal copy, because when I was working on the code, I found it to be significantly faster than using libswresample, but maybe things have changed now and with the right settings it could be as fast.

@johnsheu
Copy link
Contributor Author

johnsheu commented Jun 1, 2020

Hm, we could do this. I just need to verify the resampling configs, to make sure they match. I used the internal copy, because when I was working on the code, I found it to be significantly faster than using libswresample, but maybe things have changed now and with the right settings it could be as fast.

I'm not sure what you mean by verifying the resampling configs? This PR adds an option to the CMake build to disable the resampling entirely -- so if the user provides audio not in the sample rate of the default config, whatever it is, then analysis fails. The use case I'm thinking of is when the user already has some other facility for doing resampling, and can use that to do preprocessing first.

Also, the check failures look unrelated; I'm not sure how to trigger a rerun.

@wallisch
Copy link
Contributor

Any chance of this getting merged? This would allow the SwiftWrapper to be completely MIT licensed

@lalinsky lalinsky merged commit da9c9ae into acoustid:master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants