DynamicStrategy RefreshFrequency is hardcoded to 5s

[patcher-ms]

Describe the bug
I noticed that if even if change the refresh frequency in the configuration the template refreshes after 5 seconds. I believe this is due to this value being hardcoded to 5s

sablier/app/http/routes/strategies.go

Line 90 in 5ab29c3

RefreshFrequency: 5 * time.Second,

Context

• Sablier version: [e.g. 1.4.0-beta.4]
• Provider: [e.g. docker]
• Reverse proxy: [e.g. traefik v3.0]
• Sablier running inside a container? Yes

Expected behavior
I would expect that changing Sablier's configuration

strategy:
  dynamic:
    default-refresh-frequency: 1s

or setting the refresh frequency in a label (e.g. traefik.http.middlewares.grafana.plugin.sablier.dynamic.refreshFrequency=10s) would result in a response with the refresh frequency I configured.

Additional context
All the other values I configured are picked up correctly so I don't this this is a misconfiguration on my side.
I am not using health checks on the Docker container which could hide the issue since an health check would prevent a pod from being detected as up until the service is actually ready.

[acouvreur]

Will look it up, seems easy to fix

[acouvreur]

🎉 This issue has been resolved in version 1.4.0-beta.6 🎉

The release is available on:

• v1.4.0-beta.6
• GitHub release

Your semantic-release bot 📦🚀

[patcher-ms]

Thanks for looking into this so quickly.

Unfortunately I am still having a couple issues:

• the value used in fix: use paramter for dynamic strategy #176 comes from

  sablier/app/http/routes/strategies.go

  Line 53 in 98f0f81

  RefreshFrequency: s.StrategyConfig.Dynamic.DefaultRefreshFrequency,

  , which only looks at DefaultRefreshFrequency and not on the custom configuration coming from the label
• there is a discrepancy between the sample configuration and the yaml decoding definition the former says the config value is default-refresh-frequency but the latter tries to decode yaml:"defaultRefreshFrequency"

[acouvreur]

I'll take a look, but the value should be retrieved from the configuration first as a default value, and then overwritten by the body

[acouvreur]

🎉 This issue has been resolved in version 1.4.0 🎉

The release is available on:

• v1.4.0
• GitHub release

Your semantic-release bot 📦🚀