-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DynamicStrategy RefreshFrequency is hardcoded to 5s #175
Comments
Will look it up, seems easy to fix |
The value was using a hardcoded 5s Fixes #175
🎉 This issue has been resolved in version 1.4.0-beta.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Thanks for looking into this so quickly. Unfortunately I am still having a couple issues:
|
I'll take a look, but the value should be retrieved from the configuration first as a default value, and then overwritten by the body |
🎉 This issue has been resolved in version 1.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Describe the bug
I noticed that if even if change the refresh frequency in the configuration the template refreshes after 5 seconds. I believe this is due to this value being hardcoded to 5s
sablier/app/http/routes/strategies.go
Line 90 in 5ab29c3
Context
Expected behavior
I would expect that changing Sablier's configuration
or setting the refresh frequency in a label (e.g.
traefik.http.middlewares.grafana.plugin.sablier.dynamic.refreshFrequency=10s
) would result in a response with the refresh frequency I configured.Additional context
All the other values I configured are picked up correctly so I don't this this is a misconfiguration on my side.
I am not using health checks on the Docker container which could hide the issue since an health check would prevent a pod from being detected as up until the service is actually ready.
The text was updated successfully, but these errors were encountered: