Fix issue with loading page not showing in Traefik for h2 connections #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@acouvreur do you have any thoughts on this? Sorry for the ping, earlier you replied to my other issue and I wanted to make sure this PR didn’t fall through the cracks :) |
|
Will check if any side effect might occur without sending the content length But I might merge it soon :) |
|
🎉 This PR is included in version 1.4.0-beta.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
@all-contributors please add @patcher-ms for bug and code |
|
@patcher-ms already contributed before to bug, code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I continued my investigation of issue #165 and I discovered that when making a working request these are the headers seen by cURL:
Note that
Content-Lengthis not present. https://stackoverflow.com/questions/75091383/why-does-golang-http-responsewriter-auto-add-content-length-if-its-no-more-than talks about this and describes what's going on.Apparently this is not an issue for HTTP/1.1 connections, which are used by cURL and the browsers when there is no TLS involved.
When the request is HTTPs cURL and browsers prefer to use h2, which I guess handle headers in a different ways.
If I force cURL to use HTTP1.1 I get the loading page even for TLS requests, so this is definitely and issue related to h2.
Anyway,
Content-Lengthis never explicitly set inserveDynamicand loading pages tend to be above the threshold so I think not propagating it is the right fix for the issue.