Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(charts): sablier helm chart for kube deployement #274

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DrummyFloyd
Copy link

@DrummyFloyd DrummyFloyd commented Apr 10, 2024

Hi , like i said i n the issue, seems to be a good idea to have a chart to easily deploy sablier

  • templates
  • unittest
  • ci-lint test (ct lint/install and helm unittest)
  • readme generation docs with helm-docs
  • ct-releaser => may not fully functionnal

NB: not very used to work with gh-actions, double check ^^

Closed: #271

@acouvreur
Copy link
Owner

Hey @DrummyFloyd ! Thanks a lot for your contribution, I will look into it :)

@acouvreur
Copy link
Owner

I'm not familiar with what's being done in most projects, should we have a folder charts ? A folder helm ? Should we place the folder charts inside the folder helm ?

Also for all the CI part I'm not familiar with helm testing.

I'll need some time reviewing this 👍

This is some serious work though, thanks a lot for your contributions!

@DrummyFloyd
Copy link
Author

DrummyFloyd commented Apr 16, 2024

I'm not familiar with what's being done in most projects, should we have a folder charts ? A folder helm ? Should we place the folder charts inside the folder helm ?

no it's quite a convention the charts folders then inside u will find all yours chart look for instance the grafana-repo
but if you prefers, it up to you , just do not forget to change ct.yaml and workflows overall

Also for all the CI part I'm not familiar with helm testing.

for the CI part, is quite simple i use what i used on my own stuff + was inspired byt other open source stuff like traefik-chart
if you need some explanation do not hesitate =)
but for me the most important part is the unittest stuff, the ct install can be optionnal but could improve the test on the charts

This is some serious work though, thanks a lot for your contributions!

Np!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Kubernetes] Helm Chart ?
2 participants