Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(charts): sablier helm chart for kube deployement #274

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DrummyFloyd
Copy link

@DrummyFloyd DrummyFloyd commented Apr 10, 2024

Hi , like i said i n the issue, seems to be a good idea to have a chart to easily deploy sablier

  • templates
  • unittest
  • ci-lint test (ct lint/install and helm unittest)
  • readme generation docs with helm-docs
  • ct-releaser => may not fully functionnal

NB: not very used to work with gh-actions, double check ^^

Closed: #271

@acouvreur
Copy link
Owner

Hey @DrummyFloyd ! Thanks a lot for your contribution, I will look into it :)

@acouvreur
Copy link
Owner

I'm not familiar with what's being done in most projects, should we have a folder charts ? A folder helm ? Should we place the folder charts inside the folder helm ?

Also for all the CI part I'm not familiar with helm testing.

I'll need some time reviewing this 👍

This is some serious work though, thanks a lot for your contributions!

@DrummyFloyd
Copy link
Author

DrummyFloyd commented Apr 16, 2024

I'm not familiar with what's being done in most projects, should we have a folder charts ? A folder helm ? Should we place the folder charts inside the folder helm ?

no it's quite a convention the charts folders then inside u will find all yours chart look for instance the grafana-repo
but if you prefers, it up to you , just do not forget to change ct.yaml and workflows overall

Also for all the CI part I'm not familiar with helm testing.

for the CI part, is quite simple i use what i used on my own stuff + was inspired byt other open source stuff like traefik-chart
if you need some explanation do not hesitate =)
but for me the most important part is the unittest stuff, the ct install can be optionnal but could improve the test on the charts

This is some serious work though, thanks a lot for your contributions!

Np!

@acouvreur
Copy link
Owner

Hello @DrummyFloyd

I will create a new PR heavily inspired from your work.

I'll mark you as a co author on the commit and this PR will be referenced!

I'll close this PR once I'll submit the new one.

@DrummyFloyd
Copy link
Author

Hello @DrummyFloyd

I will create a new PR heavily inspired from your work.

I'll mark you as a co author on the commit and this PR will be referenced!

I'll close this PR once I'll submit the new one.

Np problem =)

@acouvreur
Copy link
Owner

The main issue is that the current CI you are using sets up a chart repository using the github pages.

Currently the github pages feature is used to host the documentation.

I'll check what I can do.

@acouvreur
Copy link
Owner

We should also take car of helm best practices: https://helm.sh/docs/chart_best_practices/

There are some changes to be done for sa and rbac

@acouvreur
Copy link
Owner

With the way I will be deploying multi versioned documentation, this will enable me to publish the helm chart!

Copy link

sonarcloud bot commented Jul 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

spec:
serviceAccountName: sablier-{{ .Release.Name }}
containers:
- name: sablier

Check warning

Code scanning / SonarCloud

Memory limits should be enforced Medium

Specify a memory limit for this container. See more on SonarCloud
annotations:
{{ toYaml . | nindent 8 }}
{{- end }}
spec:

Check warning

Code scanning / SonarCloud

Service account tokens should not be mounted in pods Medium

Set automountServiceAccountToken to false for this specification of kind Deployment. See more on SonarCloud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Kubernetes] Helm Chart ?
2 participants